Skip to content

Added a new cmake flag to enable isolation#501

Draft
adityapande-1995 wants to merge 2 commits into
ament:rollingfrom
adityapande-1995:aditya/test_isolation
Draft

Added a new cmake flag to enable isolation#501
adityapande-1995 wants to merge 2 commits into
ament:rollingfrom
adityapande-1995:aditya/test_isolation

Conversation

@adityapande-1995
Copy link
Copy Markdown

@adityapande-1995 adityapande-1995 commented Jan 30, 2024 •
edited
Loading

This adds a new cmake argument called "ISOLATE_TEST" to use https://github.com/adityapande-1995/linux_isolate_process for isolating a test. This would mean more tests can be run in parallel, and can speed up CI. Due to the underlying implementation using the unshare system call, this can only be used in linux.

The proposal is to add linux_isolate_process as a dependency of ament_cmake_test, so that downstream packages get it for free, and hopefully add linux_isolate_process as a core package in ROS 2.

Custom repos file : https://gist.github.com/adityapande-1995/0f05b9acf72be5fbb34e80e4342cfe26

The plan further is to add a similar pytest plugin.

cottsay
cottsay reviewed Jan 31, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also trigger a build where the flag is inverted and unconditionally enabled so we can "see what breaks" :)

Comment thread ament_cmake_test/cmake/ament_add_test.cmake Outdated
Comment thread ament_cmake_test/cmake/ament_add_test.cmake Outdated
@adityapande-1995
Reordered args
fb6680f 
Signed-off-by: Aditya Pande <[email protected]>
@adityapande-1995
Copy link
Copy Markdown
Author

adityapande-1995 commented Jan 31, 2024 •
edited
Loading

Build round 2, with isolation enabled and a parallel executor :

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Build args : --event-handlers console_cohesion+ console_package_list+ --cmake-args -DINSTALL_EXAMPLES=OFF -DSECURITY=ON -DAPPEND_PROJECT_NAME_TO_INCLUDEDIR=ON -DISOLATE_TEST=ON
Test args : --event-handlers console_cohesion+ --retest-until-pass 2 --ctest-args -LE xfail --pytest-args -m "not xfail"

Without isolation but with a parallel executor :

Build args : --event-handlers console_cohesion+ console_package_list+ --cmake-args -DINSTALL_EXAMPLES=OFF -DSECURITY=ON -DAPPEND_PROJECT_NAME_TO_INCLUDEDIR=ON
Test args : --event-handlers console_cohesion+ --retest-until-pass 2 --ctest-args -LE xfail --pytest-args -m "not xfail"

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@adityapande-1995
Copy link
Copy Markdown
Author

adityapande-1995 commented Feb 2, 2024 •
edited
Loading

TODO :

  • Make a pytest plguin out of linux_isolate_process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll left review comments

@cottsay cottsay cottsay left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adityapande-1995 @mjcarroll @cottsay